Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dates: move access of DATEFORMAT_REGEX_CACHE inside lock #57818

Closed
wants to merge 1 commit into from
Closed

Dates: move access of DATEFORMAT_REGEX_CACHE inside lock #57818

wants to merge 1 commit into from

Conversation

IanButterworth
Copy link
Member

Proposed fix for #57817.
Not validated as I don't have a mwe.

@IanButterworth IanButterworth added dates Dates, times, and the Dates stdlib module bugfix This change fixes an existing bug labels Mar 18, 2025
@IanButterworth IanButterworth requested a review from vchuravy March 18, 2025 16:00
@Octogonapus
Copy link
Contributor

I am pretty sure this is not a fix for #57817 given #57817 (comment). The problem is how pcre is handled at exit.

The other correctness problem this lock could fix is when CONVERSION_SPECIFIERS is modified while another thread is accessing DATEFORMAT_REGEX_CACHE, but that won't fault. That thread will just be using an old regex for that one call. So I don't see what else this lock adds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy Awaiting requested review from vchuravy

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug dates Dates, times, and the Dates stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanButterworth @Octogonapus