Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to force emission of const return function #57824

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add option to force emission of const return function #57824

wants to merge 2 commits into from
+11 −9

Conversation

gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented Mar 18, 2025 •
edited
Loading

This is mostly for GPUCompiler

@gbaraldi gbaraldi mentioned this pull request Mar 18, 2025
Open
@gbaraldi gbaraldi requested review from vtjnash and maleadt March 18, 2025 20:42
@maleadt maleadt added compiler:codegen Generation of LLVM IR and native code gpu Affects running Julia on a GPU labels Mar 19, 2025
maleadt
maleadt approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks!

Should we future-proof this by calling it emit_all or something, as IIUC codegen could omit other IR emissions in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt approved these changes

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code gpu Affects running Julia on a GPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbaraldi @maleadt