Add a similar method for Type{<:CodeUnits}
#57826
Open
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `similar(::CodeUnits)` works as expected by going through the
generic `AbstractArray` method. However, the fallback method hit by
`similar(::Type{<:CodeUnits}, dims)` does not work, as it assumes the
existence of a constructor that accepts an `UndefInitializer`. This can
be made to work by defining a corresponding method that returns an
`Array`.
ararslan
commented
Mar 20, 2025
| @@ -805,6 +805,8 @@ write(io::IO, s::CodeUnits) = write(io, s.s) | |||
| cconvert(::Type{Ptr{T}}, s::CodeUnits{T}) where {T} = cconvert(Ptr{T}, s.s) | |||
| cconvert(::Type{Ptr{Int8}}, s::CodeUnits{UInt8}) = cconvert(Ptr{Int8}, s.s) | |||
|
|
|||
| similar(::Type{<:CodeUnits{T}}, dims::Dims) where {T} = Array{T}(undef, dims) | |||
There was a problem hiding this comment.
An alternative (possibly better?) solution could also be
Suggested change
| similar(::Type{<:CodeUnits{T}}, dims::Dims) where {T} = Array{T}(undef, dims) | |
| similar(::Type{<:CodeUnits{T}}, dims::Dims) where {T} = similar(Array{T}, dims) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
similar(::CodeUnits)works as expected by going through the genericAbstractArraymethod. However, the fallback method hit bysimilar(::Type{<:CodeUnits}, dims)does not work, as it assumes the existence of a constructor that accepts anUndefInitializer. This can be made to work by defining a correspondingsimilarmethod that returns anArray.One could make a case that this is a bugfix since it was arguably a bug that this method didn't work given that
CodeUnitsis anAbstractArraysubtype and the othersimilarmethods work. If anybody buys that argument, it could be nice to backport this; it came up in some internal code that uses Arrow.jl and JSON3.jl together.