Add a similar method for Type{<:CodeUnits}
#57826
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
commented
Mar 20, 2025
|
Bump |
ararslan
force-pushed
the
aa/similar-codeunits
branch
from
ce6998d to
299ed24
Compare
ararslan
force-pushed
the
aa/similar-codeunits
branch
from
299ed24 to
621ab82
Compare
Currently, `similar(::CodeUnits)` works as expected by going through the
generic `AbstractArray` method. However, the fallback method hit by
`similar(::Type{<:CodeUnits}, dims)` does not work, as it assumes the
existence of a constructor that accepts an `UndefInitializer`. This can
be made to work by defining a corresponding method that returns an
`Array`.
ararslan
force-pushed
the
aa/similar-codeunits
branch
from
621ab82 to
7c1322b
Compare
mbauman
approved these changes
Jul 1, 2025
|
@mbauman, do you think this could/should be backported? It was arguably a bug that this method didn't work given that |
mbauman
added
backport 1.10
|
I'll take the application of those labels as a yes then. 😄 Thanks! |
KristofferC
pushed a commit
that referenced
this pull request
Jul 3, 2025
Currently, `similar(::CodeUnits)` works as expected by going through the
generic `AbstractArray` method. However, the fallback method hit by
`similar(::Type{<:CodeUnits}, dims)` does not work, as it assumes the
existence of a constructor that accepts an `UndefInitializer`. This can
be made to work by defining a corresponding `similar` method that
returns an `Array`.
One could make a case that this is a bugfix since it was arguably a bug
that this method didn't work given that `CodeUnits` is an
`AbstractArray` subtype and the other `similar` methods work. If anybody
buys that argument, it could be nice to backport this; it came up in
some internal code that uses Arrow.jl and JSON3.jl together.
(cherry picked from commit 8e524c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
similar(::CodeUnits)works as expected by going through the genericAbstractArraymethod. However, the fallback method hit bysimilar(::Type{<:CodeUnits}, dims)does not work, as it assumes the existence of a constructor that accepts anUndefInitializer. This can be made to work by defining a correspondingsimilarmethod that returns anArray.One could make a case that this is a bugfix since it was arguably a bug that this method didn't work given that
CodeUnitsis anAbstractArraysubtype and the othersimilarmethods work. If anybody buys that argument, it could be nice to backport this; it came up in some internal code that uses Arrow.jl and JSON3.jl together.