Show evaluated test arguments from broadcast functions #57839
+205
−139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #57825 I noticed that broadcasted functions were not we'll supported by the
@test
macro and never showed the evaluated test arguments. I've updated the stdlib to support this which required some large enough refactoring that it seemed best to make a separate PR for this change. The changes include:Expr
. This made the code harder to reason aboue than it needed to be.eval_test
intoeval_test_comparison
andeval_test_function
due to changes to the functions arguments1 .== 1
and function calls(==).(1, 1)
)_escaped_call
function which abstracts escaping all of the arguments for a function call. Doing this made it handling the special call syntax for broadcasting easier.Depends on: