add trimming of new usings_backedges and scanned_methods fields #57879
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
commented
Mar 24, 2025
| @@ -809,8 +809,14 @@ static void jl_queue_module_for_serialization(jl_serializer_state *s, jl_module_ | |||
| jl_queue_for_serialization(s, module_usings_getmod(m, i)); | |||
| } | |||
|
|
|||
| jl_queue_for_serialization(s, m->usings_backedges); | |||
| jl_queue_for_serialization(s, m->scanned_methods); | |||
| if (jl_options.trim || jl_options.strip_ir) { | |||
There was a problem hiding this comment.
Not sure if this should be tied to strip-ir or trim, but either seems ok?
JeffBezanson
commented
Mar 24, 2025
JeffBezanson
commented
Mar 24, 2025
| @@ -4,7 +4,7 @@ let exe_suffix = splitext(Base.julia_exename())[2] | |||
|
|
|||
| hello_exe = joinpath(@__DIR__, "hello" * exe_suffix) | |||
| @test readchomp(`$hello_exe`) == "Hello, world!" | |||
| @test filesize(hello_exe) < filesize(unsafe_string(Base.JLOptions().image_file))/10 | |||
| @test filesize(hello_exe) < 2000000 | |||
There was a problem hiding this comment.
For me the size is now 1633392. Not sure if this holds on all platforms but we'll find out.
There was a problem hiding this comment.
Pretty sure we only test trimming on Linux x86-64, but I'm very happy to have this test tightened anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.