Move eachregion(::AnnotatedString) implementation to Base
#57912
+333
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-organizing these definitions - no changes to the code.
topolarity
added
invalidations
backport 1.12
topolarity
changed the title
eachregion(::AnnotatedString) implementation to Base
topolarity
force-pushed
the
ct/mv-eachregion
branch
3 times, most recently
from
bafdc1b to
c1522a3
Compare
topolarity
force-pushed
the
ct/mv-eachregion
branch
from
c1522a3 to
637128e
Compare
Base needs this functionality so that it can iterate its own `AnnotatedString`s.
topolarity
force-pushed
the
ct/mv-eachregion
branch
from
637128e to
50f0bd0
Compare
|
Is this PR supposed to prevent any invalidations? I can't find such an example. I tried things like this, but the result is the same on nightly and with this PR: using StyledStrings: StyledStrings
using SnoopCompileCore: @snoop_invalidations
raw_invalidations = @snoop_invalidations begin
using CSV: CSV
end |
|
Not directly - I added the label because it's part of a longer-term plan to resolve the type piracy in StyledStrings, which should remove many invalidations |
|
I'm going to merge this, since it is unambiguously type-piracy for this to be defined outside of Base. There are still decisions to make w.r.t. solving the rest of the StyledStrings type piracy, but those can be tackled in separate PR's |
|
Cool, as you say this is an early building block and a very straightforward change 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excising part of #56194 on the way to reviving that PR.