Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base: typeassert displaysize return value #57920

Merged

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Mar 28, 2025

Improve abstract type inference. This is OK because displaysize is documented to always return a Tuple{Int, Int} value.

Also add tests.

@nsajko nsajko added the io Involving the I/O subsystem: libuv, read, write, etc. label Mar 28, 2025
@christiangnrd

This comment was marked as resolved.

@nsajko nsajko changed the title REPL: typeassert displaysize return value Base: typeassert displaysize return value Mar 28, 2025
@nsajko nsajko marked this pull request as draft March 28, 2025 20:57
@nsajko nsajko force-pushed the Base_displaysize_typeassert_return_value branch from 9f8382a to 3a95e31 Compare March 29, 2025 00:29
@nsajko nsajko marked this pull request as ready for review March 29, 2025 00:30
@nsajko nsajko added the display and printing Aesthetics and correctness of printed representations of objects. label Mar 29, 2025
Improve abstract type inference. This is OK because `displaysize` is
documented to always return a `Tuple{Int, Int}` value.

Also add tests.
@nsajko nsajko force-pushed the Base_displaysize_typeassert_return_value branch from 540fe1a to 0476ea1 Compare March 30, 2025 23:28
@KristofferC KristofferC merged commit 2f34760 into JuliaLang:master Mar 31, 2025
4 of 7 checks passed
@nsajko nsajko deleted the Base_displaysize_typeassert_return_value branch March 31, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
display and printing Aesthetics and correctness of printed representations of objects. io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants