iterators: merge duplicate iterate methods for Reverse
#58087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
added
arrays
jishnub
reviewed
Apr 12, 2025
The method bodies and state optional argument definition are exactly
the same.
The only difference between the two methods, is that the more specific
method, for `Reverse{<:AbstractArray}`, had a `@propagate_inbounds`
annotation. I simply deleted the more specific method, together with
the annotation. Deleting the annotation is consistent with the fact
that the `iterate(::AbstractArray)` method, in abstractarray.jl, has no
such annotation.
|
bump |
|
Does this impact performance in any way when applied to arrays in an inbounds context? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method bodies and state optional argument definition are exactly the same.
The only difference between the two methods, is that the more specific method, for
Reverse{<:AbstractArray}, had apropagate_inboundsmacro applied. I simply deleted the more specific method, together with the macro. Deleting the macro annotation is consistent with the fact that theiterate(::AbstractArray)method, in abstractarray.jl, has no such annotation.