Skip to content

[release-1.10] Fix application of openlibm stack markings patch #58114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

ararslan
Copy link
Member

This fixes building patched openlibm 0.8.1 without BinaryBuilder.

Note that this PR is against release-1.10. The update to openlibm 0.8.5 has not been backported to 1.10, which is why this is different than #58111.

This fixes building patched openlibm 0.8.1 without BinaryBuilder.
@ararslan ararslan force-pushed the aa/fix-openlibm-patch branch from 96131f0 to 7cf6953 Compare April 16, 2025 00:18
Copy link
Contributor

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it, but going by memory of what was the problem this looks more or less correct. And I presume you did test it locally?

@ararslan
Copy link
Member Author

I'm pretty sure I did but I kinda don't remember; did too many things yesterday

@KristofferC KristofferC merged commit ceca0c5 into release-1.10 Apr 16, 2025
5 checks passed
@KristofferC KristofferC deleted the aa/fix-openlibm-patch branch April 16, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants