Skip to content

Reapply "precompile: fail in (closer to) linear time and linear error messages" with fixes #60000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reapply "precompile: fail in (closer to) linear time and linear error messages" with fixes #60000

wants to merge 2 commits into from
+342 −111

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 31, 2025 •
edited
Loading

With thanks to Ian and Kristoffer for pointing out the needed fixes

  • Will need: runtests(ALL, configuration = (goal=:load,), vs_configuration = (goal=:load,)) before merge

@giordano giordano added needs pkgeval Tests for all registered packages should be run with this change re-land This relands a PR that was previously merged but was later reverted. labels Oct 31, 2025
@vtjnash
Copy link
Member Author

vtjnash commented Nov 4, 2025

@nanosoldier runtests(ALL, configuration = (goal=:load,), vs_configuration = (goal=:load,))

@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing don't squash Don't squash merge and removed needs pkgeval Tests for all registered packages should be run with this change labels Nov 4, 2025
@KristofferC KristofferC mentioned this pull request Nov 5, 2025
Open
17 tasks
@nanosoldier
Copy link
Collaborator

nanosoldier commented Nov 5, 2025

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

✖ Packages that failed

327 packages failed only on the current version.

  • Package fails to precompile: 213 packages
  • Illegal method overwrites during precompilation: 108 packages
  • Package requires a missing binary dependency: 2 packages
  • Test duration exceeded the time limit: 4 packages

949 packages failed on the previous version too.

~ Packages that at least loaded

2 packages successfully loaded only on the current version.

  • Other: 2 packages

8941 packages successfully loaded on the previous version too.

➖ Packages that were skipped altogether

1 packages were skipped only on the current version.

  • Package could not be installed: 1 packages

889 packages were skipped on the previous version too.

@vtjnash vtjnash removed the merge me PR is reviewed. Merge when all tests are passing label Nov 5, 2025
@vtjnash
precompile: fix deps list for extensions relying on stdlibs
12adf71 
Some packages add extensions to stdlibs, so we should not have
prohibited precompiling those. This broke Compat, which adds an
extension to LinearAlgebra.
@vtjnash
Reapply "precompile: fail in (closer to) linear time and linear error…
cd0d942 
… messages"

This reverts commit 81dbb72.
@vtjnash
Copy link
Member Author

vtjnash commented Nov 7, 2025

We may need to completely rethink how extensions to stdlibs work again, since this is now just a hack job to only be partly badly implemented, since the trigger sets being used for computing the safe operation are entirely wrong if any of them got added into a custom sysimage.

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport 1.13 don't squash Don't squash merge merge me PR is reviewed. Merge when all tests are passing re-land This relands a PR that was previously merged but was later reverted.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vtjnash @nanosoldier @giordano @KristofferC