Skip to content

Tilde expansion in REPL shell completion #7617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2015
Merged

Tilde expansion in REPL shell completion #7617

merged 1 commit into from
Mar 27, 2015

Conversation

garborg
Copy link
Contributor

@garborg garborg commented Jul 15, 2014

Search relative to homedir() if path begins with ~.

@StefanKarpinski
Copy link
Member

Technically, this is not quite correct. It should only apply args matching r"^~(?:/|$)" – the ~ must either be the entire argument or be followed by a /, otherwise it indicates a different user's home.

@quinnj
Copy link
Member

quinnj commented Jul 15, 2014

Also see #1136 and #3919 for related issues.

@garborg
Copy link
Contributor Author

garborg commented Jul 15, 2014

Interesting, thanks for the links -- I added the basic correction described above, figuring correctness doesn't outweigh convenience in tab completion like it does in the linked issues.

@blakejohnson
Copy link
Contributor

@garborg would you mind rebasing this?

@garborg
Copy link
Contributor Author

garborg commented Mar 26, 2015

@blakejohnson, done. Sorry for the delay.

@blakejohnson
Copy link
Contributor

This seems like a reasonable step in the right direction, so I am inclined to merge it. Any objections?

StefanKarpinski added a commit that referenced this pull request Mar 27, 2015
Tilde expansion in REPL shell completion
@StefanKarpinski StefanKarpinski merged commit b046860 into JuliaLang:master Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants