Update windows progress immediately #1282
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xgdgsc as I'm not on windows, can you try building this and see if it fixes the issue? https://github.com/JuliaLang/juliaup/wiki/Developing-Juliaup#to-build-juliaup-locally |
|
Built. Same behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1281
Using Claude:
On Windows, the download process uses the Windows Runtime DataReader API through a custom
DataReaderWrapstruct. The issue was:LoadAsync()downloads data from the network into a Windows bufferReadBytes()copies data from the Windows buffer to the Rust bufferread() method returnedThis meant the actual network download (step 1) completed before the progress bar updated (after step 3), causing the visible lag.