-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lazy module loading #128
lazy module loading #128
Conversation
@johnnychen94 I'm running in some world age issue, see the failing tests. Do you know how to fix them? |
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
- Coverage 33.26% 29.64% -3.62%
==========================================
Files 38 39 +1
Lines 1527 1565 +38
==========================================
- Hits 508 464 -44
- Misses 1019 1101 +82
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall change looks good to me although I'm not confident that users want the @require
error -- I understand how you want to reduce the package loading latency, just unsure if it's a good direction.
Said that, if we introduce the "hard" requirement on package loading, then we might need to add some explaination before/after the https://juliaml.github.io/MLDatasets.jl/stable/#Basic-Usage to tell users how to properly handle this.
Because the hard requirement will break people's code, this will need a 0.7.0 version bump.
Fix #126 using FileIO and a similar method for lazy loading modules.
Time-to-first-MNIST goes from 14.5s to 5.5s.