Define new at-generate_jll_init macro to replace hardcoded __init__#55
Open
giordano wants to merge 1 commit into
Open
Define new at-generate_jll_init macro to replace hardcoded __init__#55giordano wants to merge 1 commit into
at-generate_jll_init macro to replace hardcoded __init__#55giordano wants to merge 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 54.05% 54.86% +0.81%
==========================================
Files 7 7
Lines 222 226 +4
==========================================
+ Hits 120 124 +4
Misses 102 102
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
staticfloat
approved these changes
May 14, 2023
Member
|
Seems like a good idea towards flexibility. Beyond this, could a JLL be defined by a set of TOMLs of products etc. for each platform and the package just be something like Where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case in the future we will have a different mechanism than
__init__. This also makes #54 easier, the wrapper footer could be included directly into this macro.