Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVM_full] Add LLVM_full, LLVM_full_assert 20 recipes #10747

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[LLVM_full] Add LLVM_full, LLVM_full_assert 20 recipes #10747

wants to merge 8 commits into from

Conversation

Zentrik
Copy link
Contributor

@Zentrik Zentrik commented Mar 14, 2025

No description provided.

@Zentrik
Copy link
Contributor Author

Zentrik commented Mar 14, 2025

I'll wait for pkgeval on the new llvm commit before pushing.

@Zentrik
Copy link
Contributor Author

Zentrik commented Mar 15, 2025 •
edited
Loading

Ok, I guess bundled in the assert build is supposed to be a symlink.
Looks like my git config was screwed up for this repo with core.filemode set to false and core.symlinks set to false, which confused me as the bundled files locally were just paths and not symlinks.
It seems that was also causing vscode to hide git changes when I changed the bundled file to a symlink from a file, so I thought git didn't care about the file type.

Zentrik
Zentrik commented Mar 16, 2025
View reviewed changes
L/LLVM/LLVM_full@20/bundled/patches/0800-mingw-fix.patch
#define GET_FUNCTION_ADDRESS(fn) &fn
#else
-#define GET_FUNCTION_ADDRESS(fn) __builtin_function_start(fn)
+#define GET_FUNCTION_ADDRESS(fn) (void *)(&fn)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new patch, without it the compilation fails without any message. Maybe a compiler bug, I'm not sure.

L/LLVM/common.jl
@@ -122,6 +123,7 @@ else
fi
if [[ "${LLVM_MAJ_VER}" -gt "13" ]]; then
CMAKE_FLAGS+=(-DMLIR_BUILD_MLIR_C_DYLIB:BOOL=ON)
CMAKE_FLAGS+=(-DMLIR_LINK_MLIR_DYLIB:BOOL=OFF)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to not set this nor did LLVM, now LLVM sets this to LLVM_LINK_LLVM_DYLIB. We set that to true so disable this explicitly to prevent some issues on windows, llvm/llvm-project#119408 (comment). Maybe we want to only disable this on windows/ try and fix the windows issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion honestly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should affect functionality for users of mlir, so not worried

@giordano
Copy link
Member

Feel free to merge this when you're ready, this looks good for me.

@Zentrik
Copy link
Contributor Author

Zentrik commented Mar 18, 2025

I'll try and see if I can figure out the Darwin issue before merging, JuliaLang/julia#57658 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zentrik @giordano