[GAP] Update to 4.15.0#11987
Merged
Merged
Conversation
lgoettgens
commented
Sep 1, 2025
| install-sysinfo: SYSINFO_CPPFLAGS = -I${includedir}/gap -I${includedir} $(GAP_DEFINES) | ||
| install-sysinfo: SYSINFO_CPPFLAGS = -I${includedir}/gap/extra $(GAP_DEFINES) | ||
| -install-sysinfo: SYSINFO_LDFLAGS = $(ABI_CFLAGS) | ||
| +install-sysinfo: SYSINFO_LDFLAGS = $(ABI_CFLAGS) -L$(libdir) -lgap |
Member
Author
There was a problem hiding this comment.
@fingolfin Is this patch something that could be upstreamed to gap? Or is this specific to the way GAP.jl compiles kernel extensions?
Member
There was a problem hiding this comment.
For now this is GAP.jl specific. Upstreaming this cleanly is a bit hairy, see gap-system/gap#5780
This was referenced Sep 1, 2025
Member
Author
|
@fingolfin this should be good to go now |
fingolfin
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not be merged, but instead wait for the actual 4.15.0 release. But I wanted to build a local copy already to test with Oscar, and wanted to make all changes to patches etc. available.
The update form the beta1 to the release should then be a minimal change to this PR once the release is out.