[SimpleBLE] Add support for macOS and fixed linux linking bug#14200
Open
AwesomeQuest wants to merge 8 commits into
Open
[SimpleBLE] Add support for macOS and fixed linux linking bug#14200AwesomeQuest wants to merge 8 commits into
AwesomeQuest wants to merge 8 commits into
Conversation
The explicit dbus dependency was breaking the functionality of the library by loading its own instance instead of calling the one already on the os
bug fix
Author
|
I was decived by AI I'm sorry, I'll do better |
AI disclosure, this issue was entirely fixed by AI. I think it looks reasonable and it works (as far as I can tell)
giordano
requested changes
Jul 13, 2026
Comment on lines
+23
to
+27
| # dbus source: built locally for Linux to satisfy CMake find_package | ||
| # without pulling in Dbus_jll as a runtime dependency (which breaks | ||
| # communication with the system bus daemon). | ||
| ArchiveSource("https://dbus.freedesktop.org/releases/dbus/dbus-1.16.2.tar.xz", | ||
| "0ba2a1a4b16afe7bceb2c07e9ce99a8c2c3508e5dec290dbb643384bd6beb7e2"), |
Member
There was a problem hiding this comment.
Use the existing JLL as a Dependency
Author
There was a problem hiding this comment.
Since in my testing, when Dbus_jll is included as a dependency it causes a linking issue preventing simpleble from connecting to bluetooth.
Author
There was a problem hiding this comment.
would you be willing to let me test this by letting this pull request through? if I'm wrong then I'll just switch linux to prebuilt binaries.
Member
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
ok, I've made the change. is this alright?
giordano
changed the title
Fixed to use Dbus_jll at build time but not runtime
AwesomeQuest
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The explicit dbus dependency was breaking the functionality of the library by loading its own instance instead of calling the one already on the os