Port improvements from ParallelProcessingTools #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some use cases need to call elastic_worker, so it should be part of the API. Also rename stdout_to_master to forward_stdout, it's clearer. Non-breaking since stdout_to_master was never documented.
|
Tbh I'm not terribly familiar with the |
The name of the field is confusing. It's much cleaner for the users to call `get_connect_cmd` directly. Workers may be added in different ways to the same ElasticManager and require a different startup. Also, `get_connect_cmd` was not using printing_kwargs for it's kwargs by default, which was inconsistent.
Removing ElasticManager.printing_kwargs may be considered breaking, it only affects show(::ElasticManager) but it was documented in the README.
oschulz
force-pushed
the
ppt-improvements
branch
from
1b9de83 to
1851da5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 93.33% 91.75% -1.59%
==========================================
Files 2 2
Lines 90 97 +7
==========================================
+ Hits 84 89 +5
- Misses 6 8 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Test are fixed now. |
Moelf
approved these changes
Mar 31, 2025
|
Still tracking down an issue with persistent tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.