throw if no test items found#216
Merged
Merged
Conversation
ce2e663 to
6b5b2d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's always seemed slightly odd that running 0 tests is a "success", in #215 we at least made it look less successful by logging a warning, but ultimately this doesn't catch issues (like we've seen at RAI) where e.g. changes in CI test setup leads to some job running 0 tests and therefore the job succeeding and therefore the issue (that we're no longer running tests) being missed.
If you
runtestsand fail to run any tests, i think that should be an error. So this PR makes it an error.Here's how it looks:
Note we follow the precendent of
Test.TestSetExceptionand print just theERROR: ...line without a subsequent backtracee.g. compare this where there's no backtrace after the final
Error: ...lineThis PR also updates the error when the file doesn't exist (when
validate_paths=true, or no valid files were given, resulting in no testitems):