Skip to content

Adapt Pkg.Operations.prune_manifest call for 1.12#98

Merged
Drvi merged 3 commits intomainfrom
td-prune-manifest-1.12
Aug 6, 2025
Merged

Adapt Pkg.Operations.prune_manifest call for 1.12#98
Drvi merged 3 commits intomainfrom
td-prune-manifest-1.12

Conversation

@Drvi
Copy link
Copy Markdown
Member

@Drvi Drvi commented Aug 5, 2025

The signature of the function has changed when workspaces were introduced to Pkg (diff)

Co-authored-by: Nick Robinson <npr251@gmail.com>
@nickrobinson251
Copy link
Copy Markdown
Member

idk how releases work for TestEnv.jl so tagging @oxinabox @KristofferC @davidanthoff -- can we just bump the Project.toml version and run registrator or is this package weird somehow? (i think it used to be?)

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 8.75%. Comparing base (b652737) to head (eb19b98).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/julia-1.11/activate_set.jl 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b652737) and HEAD (eb19b98). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b652737) HEAD (eb19b98)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #98       +/-   ##
==========================================
- Coverage   20.66%   8.75%   -11.92%     
==========================================
  Files          27      28        +1     
  Lines         692     617       -75     
==========================================
- Hits          143      54       -89     
- Misses        549     563       +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oxinabox
Copy link
Copy Markdown
Member

oxinabox commented Aug 6, 2025

It is no longer weird.

@nickrobinson251
Copy link
Copy Markdown
Member

Lovely. Can you bump the Project.toml version, @Drvi ? (Then merge and release if you have permissions, or let me know if not)

@Drvi Drvi merged commit ca85c19 into main Aug 6, 2025
52 of 67 checks passed
@Drvi Drvi deleted the td-prune-manifest-1.12 branch August 6, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants