Scanner flow - #42
Open
austensen wants to merge 32 commits into
Open
Conversation
✅ Deploy Preview for demo-rent-history ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely reworks the scanner flow from the prototype version we still had up.
There is a lot of logic to this but I've tried to split it up for as much clarity as possible, and there is a readme in the folder that documents the flow that would be the best reference for the overall architecture while you're reviewing and our future reference.
In addition to the scanner itself I ended up implementing the document view modal as well since it made sense for the page cards and some of the fetching image files logic to be reusable.
There will still need to be a lot more QA especially on different devices, and there are a number of pending design decisions, but this should be all of the main working flow (except for camera acccess). Here are a few of the open items:
I have temporarily set the auth demo heroku verser to the companion PR branch, but that will probably need to be reset as all the other PRs get merged into
otp-project.Companion backend PR: https://github.com/JustFixNYC/auth-provider/pull/166