Skip to content

Scanner flow - #42

Open
austensen wants to merge 32 commits into
mainfrom
scanner-flow
Open

Scanner flow#42
austensen wants to merge 32 commits into
mainfrom
scanner-flow

Conversation

@austensen

@austensen austensen commented Jul 8, 2026

Copy link
Copy Markdown
Member

NOTE: first merge in #43 (opened prs out of order)

Completely reworks the scanner flow from the prototype version we still had up.

There is a lot of logic to this but I've tried to split it up for as much clarity as possible, and there is a readme in the folder that documents the flow that would be the best reference for the overall architecture while you're reviewing and our future reference.

In addition to the scanner itself I ended up implementing the document view modal as well since it made sense for the page cards and some of the fetching image files logic to be reusable.

There will still need to be a lot more QA especially on different devices, and there are a number of pending design decisions, but this should be all of the main working flow (except for camera acccess). Here are a few of the open items:

  • styles for error callout with cta to add more pages when gap in reg years detected
  • camera access phase. I noted in figma, but I worry that the very specific instructions we have will be confusing since it varies by device/browser how to enable camera. I also am finding that just going back and attempting to relaunch shows the prompt again so maybe it isn't always needed. I haven't fully implemented the idea of it automatically detecting when the camera becomes available, and I'm not sure that's possible or desirable anymore.

I have temporarily set the auth demo heroku verser to the companion PR branch, but that will probably need to be reset as all the other PRs get merged into otp-project.

Companion backend PR: https://github.com/JustFixNYC/auth-provider/pull/166

@austensen
austensen changed the base branch from login-page to main July 8, 2026 20:55
@netlify

netlify Bot commented Jul 8, 2026

Copy link
Copy Markdown

Deploy Preview for demo-rent-history ready!

Name Link
🔨 Latest commit 5937853
🔍 Latest deploy log https://app.netlify.com/projects/demo-rent-history/deploys/6a6397d9e9c5fe0008cb2bae
😎 Deploy Preview https://deploy-preview-42--demo-rent-history.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@austensen
austensen changed the base branch from main to login-page July 9, 2026 23:11
@austensen
austensen changed the base branch from login-page to rent-question July 10, 2026 15:45
Base automatically changed from rent-question to main August 26, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant