Reorder Address and Rent pages in flow - #47
Open
austensen wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion backend PR: https://github.com/JustFixNYC/auth-provider/pull/170
For planned changes to flow to improve scanner wait time UX we need to first reorder the steps to start with address, then rent, then scanner.
Address page
Now we don't use the extracted address to pre-fill the address step (GET address endpoint removed from backend too) so remove that useEffect and simplify the UI. Now the user's new history DB record is created on submit of address (only on the first submit).
Next on Address navigates to Rent Question still.
Rent Question
The step page itself doesn't change, but now on Next it navigates to scanner, not analysis, so the
run-analysisapi call is removed.We also need to update the mapping of BE
LAST_STEP_REACHEDordered values to pages of the FE flow.