Scan flow wait - #49
Open
austensen wants to merge 21 commits into
Open
Conversation
✅ Deploy Preview for demo-rent-history ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Refactor the scanner to create a separate scan-review page instead of using a phase screen of the scanner page. Things were getting too long and complicated in a single scanner.tsx file. Now there is also better handling of scanner launch, redirects after scanning based on intent (rescanning, adding pages, etc). (More will be done to simplify the scan-review page now that we have a new plan for the error message and prompt to scan more/rescan.) docs and tests updated as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion BE PR: https://github.com/JustFixNYC/auth-provider/pull/172
Wires the frontend to the new scan pipeline contract so the happy path skips in-app scan review and shows a compiling wait screen while the backend processes pages.
COMPILING,REPORT, finalize-scan, scan-pipeline-status)historyResumePath; bootstrap redirects to/compilingwhen step isCOMPILINGor pipeline is non-terminalCompilingWaitingPagewith milestone checklist, ~1.5s pipeline polling, auto-nav oncomplete/needs_rescan, and FlowNav on back-navigationfinalize-scan→/compiling; rescan path keeps scan-review, failure callouts, andSkipOrRescanModal; best-effort finalize on tab hideThe scanner.tx file was getting way too long and complicated, so I have also done a refactor pass to clean things up a bit - see #51 . This adds a new separate scan-review page, and more hooks to better separate out functionality like for launching and relaunching the dynamsoft scanner and navigating back and forth through the scan flow.
Error handling also added for a failed scan launch (copy and design for error message to be updated later - need to share with Corey)
The scan-review page itself is still the old version. A separate set of PRs will add the page number scan extraction, add that to the scan-review api response, and implement the new simplified ui for the page without images and with a new error message.