-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Debug for all types that work with QDebug #1162
Conversation
Debug
for all types that work with QDebug
Debug
for all types that work with QDebug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 12446 12446
=========================================
Hits 12446 12446 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jnbooth, thank you for this contribution!
It's great to see you're using CXX-Qt actively and I'm very happy to see the improvements that come out of it 😃
This PR mostly looks good. I believe it can be simplified a little bit more, as the toQString
function should actually not be necessary anymore, and there are a few nitpicks to take care of.
Then we should be able to merge this 🥳
Hi @jnbooth sorry for the late reply. I'm still in favor of accessing the toString function directly. |
1990db9
to
f81ade3
Compare
@LeonMatthesKDAB I've done that and merged in the latest changes, but now the tests seem to be broken and I don't know why... |
1d7942f
to
01f4bfb
Compare
Appears CI is still failing due to a clippy warning
|
@ahayzen-kdab Fixed! |
bfb5a39
to
a28c1c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @jnbooth 🚀
This PR adds
Debug
implementations to all types that a QDebug data stream accepts.Note: Some types incorrectly used QDebug output to implement
Display
instead ofDebug
. This PR does not remove those implementations because that would be a breaking change, but they probably should be removed for the next major release.