cargo: add the lock file, this should help sccache #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
force-pushed
the
add-cargo-lock-file
branch
2 times, most recently
from
fd41942 to
7b6b89e
Compare
LeonMatthesKDAB
approved these changes
Feb 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 12438 12438
=========================================
Hits 12438 12438 ☔ View full report in Codecov by Sentry. |
We have been seeing sccache decide that the caches are not the same one of the causes looks to be, eg the cc crate, updating. Also there was a change to the Rust policy of not commiting lock files for Rust libraries. https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
ahayzen-kdab
force-pushed
the
add-cargo-lock-file
branch
from
7b6b89e to
7fcf2a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been seeing sccache decide that the caches are not the same one of the causes looks to be, eg the cc crate, updating.
Also there was a change to the Rust policy of not commiting lock files for Rust libraries.
https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html