Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: remove unused platform name (from vcpkg details) #1193

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ahayzen-kdab
Copy link
Collaborator

Requires #1191

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (70f555f) to head (409e194).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1193   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines        12438     12438           
=========================================
  Hits         12438     12438           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Corrosion sets the --target flag to rustc which means
that crates are built in the target sub folder. Ensure
that other places that call cargo directly reuse this
same folder by setting CARGO_BUILD_TARGET.
This is likely not required anymore.
@ahayzen-kdab ahayzen-kdab force-pushed the ci-remove-unused-directory branch from 435ba12 to 409e194 Compare February 18, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant