Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cxx-qt-gen: move #[qinvokable] to be inside extern "RustQt" #581

Merged

Conversation

ahayzen-kdab
Copy link
Collaborator

Requires #580

Closes #558

@ahayzen-kdab ahayzen-kdab added the 🥳🎉 1.0 This issue is part of stabilization for 1.0 release label Jun 8, 2023
@ahayzen-kdab ahayzen-kdab force-pushed the 558-move-qinvokable-into-extern-rustqt branch 2 times, most recently from be13c90 to ec3d938 Compare June 9, 2023 14:35
@ahayzen-kdab ahayzen-kdab changed the title WIP: cxx-qt-gen: move #[qinvokable] to be inside extern "RustQt" cxx-qt-gen: move #[qinvokable] to be inside extern "RustQt" Jun 9, 2023
@ahayzen-kdab ahayzen-kdab force-pushed the 558-move-qinvokable-into-extern-rustqt branch 2 times, most recently from 4b9cb99 to d50cce4 Compare June 9, 2023 16:54
@ahayzen-kdab ahayzen-kdab force-pushed the 558-move-qinvokable-into-extern-rustqt branch from d50cce4 to afbdbc3 Compare June 12, 2023 10:16
@ahayzen-kdab ahayzen-kdab marked this pull request as ready for review June 12, 2023 10:16
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking better :)

@Be-ing Be-ing merged commit 1b5bf8d into KDAB:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥳🎉 1.0 This issue is part of stabilization for 1.0 release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move #[qinvokable] into an extern "RustQt" block/outside the bridge
2 participants