Setup CI with Github Actions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonMatthesKDAB
force-pushed
the
setup-ci
branch
3 times, most recently
from
0dd17cb to
78be53d
Compare
Failing fast means we won't know if all platforms are affected or whether it's just a single platform that's problematic. So disable this, we're failing fast enough anyway.
LeonMatthesKDAB
force-pushed
the
setup-ci
branch
8 times, most recently
from
312bde3 to
dd2bb5c
Compare
narnaud
requested changes
Jun 6, 2024
narnaud
previously approved these changes
Jun 7, 2024
For now, drop support for std::format. It's not supported by the compilers used in our CI on ubuntu & macOS At least on my local machine, this means we need to disable -Werror, as one of the templates in the bundled format library produces a -Werror=dangling-reference. We should try to reenable this when possible.
This hopefully fixes macOS CI
In CI, we want to be as close to real deployment as possible, which would be release/release with debug information.
This should allow us to reenable -Werror. It might even fix the SegFault we've experienced in CI on Windows 🤞
Test whether this finally solves our Windows CI issues
narnaud
force-pushed
the
setup-ci
branch
2 times, most recently
from
4b67296 to
47b47f5
Compare
Change-Id: I2d94de3c722afdf25b1a9d20b1288dece9d94969
Just use the fmt lib bundled with it. Change-Id: I83d9974ebe63e74dee947f7b7d6cabfb959c6c83
Change-Id: I413f05fa409294978b470afd393eb6fa02867fba
narnaud
force-pushed
the
setup-ci
branch
5 times, most recently
from
b416813 to
752d137
Compare
Also when running the tst_knut. Change-Id: I56f7fa34d45cd2236511427546130dd1d006717e
narnaud
approved these changes
Jun 10, 2024
|
Unfortunately I cannot formally approve, as I'm the author of the PR, but this PR is good enough for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First set up to build & test knut using Github Actions instead of our own CI.
This is meant to be a first working version, not a complete CI setup.
Remaining ToDos after merging this PR can be found in #3