Fix memory leaks #239
Open
Fix memory leaks #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix memory leaks regarding: - Code file viewer - UI file viewer - Slint file viewer - Image file viewer - TS translation file viewer - Script panel
narnaud
requested changes
Feb 26, 2025
| @@ -41,7 +41,7 @@ void QmlView::runQml() | |||
|
|
|||
| const QString qmlFilePath = document()->fileName(); | |||
|
|
|||
| auto *qmlView = new QQuickView(); | |||
| auto *qmlView = new QQuickView(this->window()->windowHandle()); | |||
There was a problem hiding this comment.
It doesn't work as expected.
It should show a new window (I suppose that's the reason why there wasn't any parents).
A way to fix that would be to use Delete_on_Close widget attribute.
|
Btw, make sure to use conventional commits for your commit, and properly initialize pre-commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix memory leaks regarding: