Implement Display for HashParts instead of ToString directly#92
Merged
Keats merged 2 commits intoKeats:masterfrom Aug 18, 2025
Merged
Implement Display for HashParts instead of ToString directly#92Keats merged 2 commits intoKeats:masterfrom
Keats merged 2 commits intoKeats:masterfrom
Conversation
Owner
|
Looks like a legit test failure? |
Contributor
Author
|
Oops! I hadn't noticed that one of the tests was using |
Keats
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for ToString states that
The ToString implementation also used the old default version (2y).
HashParts::format()can be called instead which uses the new default version (2b). This required changingHashParts::format()to take a reference toselfinstead of consuming it.