This repository was archived by the owner on Jan 6, 2022. It is now read-only.
Sandbox.Game.MyInventory IsConnected is not thread safe#574
Open
Dummy0815 wants to merge 1 commit intoKeenSoftwareHouse:masterfrom
Open
Sandbox.Game.MyInventory IsConnected is not thread safe#574Dummy0815 wants to merge 1 commit intoKeenSoftwareHouse:masterfrom
Dummy0815 wants to merge 1 commit intoKeenSoftwareHouse:masterfrom
Conversation
|
The code in question is no longer in production codebase of SE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the 'reachableVertices' list is declared as field the usage of this list inside IsConnected is not thread safe.
The list is only used inside the function and cleared before every usage, I suggest to use an local list instead.