-
Notifications
You must be signed in to change notification settings - Fork 1
Prepare v11 support #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare v11 support #367
Conversation
0705f18
to
7917714
Compare
7917714
to
c3df671
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of small stuff. A few not so small.
tests/resources/scenario_generation/api/train_predictor/ref/SpliceJunction._kh
Show resolved
Hide resolved
c3df671
to
524f8be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second round.
khiops/core/internals/tasks/detect_data_table_format_with_dictionary.py
Outdated
Show resolved
Hide resolved
524f8be
to
fb040a1
Compare
fb040a1
to
59dd770
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found with the typos
tool:
error: `intepretation` should be `interpretation`
--> khiops/samples/samples.py:788:15
|
788 | """Builds intepretation model for existing predictor
| ^^^^^^^^^^^^^
|
error: `intepretation` should be `interpretation`
--> khiops/samples/samples.py:815:17
|
815 | print(f"The intepretation model is '{interpretor_file_path}'")
| ^^^^^^^^^^^^^
|
error: `intepretation` should be `interpretation`
--> khiops/samples/samples.ipynb:835:13
|
835 | "Builds intepretation model for existing predictor\n\n It calls `~.api.train_predictor` and `~.api.interpret_predictor` only with\n their mandatory parameters.\n \n"
| ^^^^^^^^^^^^^
|
error: `intepretation` should be `interpretation`
--> khiops/samples/samples.ipynb:866:19
|
866 | "print(f\"The intepretation model is '{interpretor_file_path}'\")"
| ^^^^^^^^^^^^^
|
error: `Intepretation` should be `Interpretation`
--> khiops/core/internals/tasks/interpret_predictor.py:36:12
|
36 | // Intepretation settings
| ^^^^^^^^^^^^^
|
error: `intepretation` should be `interpretation`
--> khiops/core/internals/tasks/interpret_predictor.py:50:18
|
50 | // Build intepretation dictionary
| ^^^^^^^^^^^^^
|
error: `intepret` should be `interpret`
--> khiops/core/api.py:318:35
|
318 | "'khiops.core.api.intepret_predictor' function is not supported "
| ^^^^^^^^
|
error: `intepretation` should be `interpretation`
--> khiops/core/api.py:825:19
|
825 | r"""Builds an intepretation dictionary from a predictor
| ^^^^^^^^^^^^^
|
error: `intepretor` should be `interpreter`
--> khiops/core/api.py:833:5
|
833 | intepretor_file_path : str
| ^^^^^^^^^^
|
error: `intepretor` should be `interpreter`
--> khiops/core/api.py:834:21
|
834 | Path to the intepretor dictionary file.
| ^^^^^^^^^^
|
error: `intepretation` should be `interpretation`
--> khiops/core/api.py:836:70
|
836 | Maximum number of variable importances to be selected in the intepretation
| ^^^^^^^^^^^^^
|
error: `intepretation` should be `interpretation`
--> khiops/core/api.py:845:9
|
845 | intepretation model. Min length: 0. Max length: the total number of variables
| ^^^^^^^^^^^^^
|
error: `intialization` should be `initialization`
--> tests/test_khiops_integrations.py:202:51
|
202 | # Get KHIOPS_API_MODE as set after runner intialization
| ^^^^^^^^^^^^^
|
error: `overriden` should be `overridden`
--> tests/test_remote_access.py:104:22
|
104 | """To be overriden by descendants"""
| ^^^^^^^^^
|
After this it should be ok.
59dd770
to
27f6d7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 3 minor things.
And make sure pre-commit passes.
32620bf
to
4a936d8
Compare
@folmos-at-orange : Please check commit 8e6c19f. |
4a936d8
to
774517d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but unless you fix pylint you won't be able to merge (pre-commit it is the only required check).
- drop deprecated arguments - add new arguments - deprecate results_dir - drop all previous v11 deprecations
If a log file path is supplied by the user, then keep the log for subsequent user inspection.
…aries Deprecate previous data-path '`'-based convention.
Indeed, backward compatibility with pre-v11 Khiops versions has been dropped.
Thusly, stop disambiguating Khiops paths, as the API mode ensures that paths can only be relative to the current working directory.
Only keep list-like, convertible to NumPy arrays, input observables.
- propagate Core API updates to parameter passing tests - propagate secondary-table path update to sklearn tests
- update Core API calls to the v11 Core API - drop all sklearn-specific deprecated Khiops estimator fields - drop deprecated `key` dataset attribute - take into account dataset deprecation drops - drop deprecated sklearn samples
Thus, the baseline model (starting with (B_)) is taken account of, but is not used (so that regressions are not entailed).
See the comment KhiopsML/khiops#626 (comment) of Khiops core issue KhiopsML/khiops#626 for the full rationale.
Also update the testing Docker images accordingly.
774517d
to
c624616
Compare
Closes #325, #329, #236, #241, #81, #77.
Supersedes PR #366 .
TODO Before Asking for a Review
dev
(ormain
for release PRs)Unreleased
section ofCHANGELOG.md
(no date)index.html