Skip to content

Fix: updated assertions to accept numbers as described #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sepci0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: updated assertions to accept numbers as described #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/engineInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ function inputClear()
* @memberof Input */
function keyIsDown(key, device=0)
{
ASSERT(isString(key), 'key must be a number or string');
ASSERT(isString(key) || isNumber(key), 'key must be a number or string');
ASSERT(device > 0 || typeof key !== 'number' || key < 3, 'use code string for keyboard');
return !!(inputData[device]?.[key] & 1);
}
Expand All @@ -115,7 +115,7 @@ function keyIsDown(key, device=0)
* @memberof Input */
function keyWasPressed(key, device=0)
{
ASSERT(isString(key), 'key must be a number or string');
ASSERT(isString(key) || isNumber(key), 'key must be a number or string');
ASSERT(device > 0 || typeof key !== 'number' || key < 3, 'use code string for keyboard');
return !!(inputData[device]?.[key] & 2);
}
Expand All @@ -127,7 +127,7 @@ function keyWasPressed(key, device=0)
* @memberof Input */
function keyWasReleased(key, device=0)
{
ASSERT(isString(key), 'key must be a number or string');
ASSERT(isString(key) || isNumber(key), 'key must be a number or string');
ASSERT(device > 0 || typeof key !== 'number' || key < 3, 'use code string for keyboard');
return !!(inputData[device]?.[key] & 4);
}
Expand Down