feat(mobile): rebuild the chat tab on the harness SDK - #5895
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe follow-up fix resolves the prior moved-chat cleanup finding: Files Reviewed (2 files)
Previous Review Summaries (13 snapshots, latest commit 465cc6c)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 465cc6c)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe fix commit resolves the three prior findings; the only new issue is that the moved-chat test cleanup is a no-op, leaving the move pointer and a live session across tests. Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (7 files)
Fix these issues in Kilo Cloud Previous review (commit 2573d62)Status: 3 Issues Found | Recommendation: Address before merge Executive SummaryThree residual issues in the new chat registry and hook: a failed reopen leaks its session scope, the Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (14 files)
Fix these issues in Kilo Cloud Previous review (commit 8f2d387)Status: 7 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (45 files)
Fix these issues in Kilo Cloud Previous review (commit b374fb3)Status: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Previous review (commit e585a7e)Status: No Issues Found | Recommendation: Merge Files Reviewed (31 files)
Previous review (commit 326f2c3)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous review (commit a7e6c90)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous review (commit 02d4575)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (10 files)
Fix these issues in Kilo Cloud Previous review (commit fee11c2)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (10 files)
Fix these issues in Kilo Cloud Previous review (commit 5c686fd)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (3 files)
Fix these issues in Kilo Cloud Previous review (commit 737d3e6)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (3 files)
Fix these issues in Kilo Cloud Previous review (commit a5fa1e0)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (10 files)
Fix these issues in Kilo Cloud Previous review (commit 3f6eee7)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (38 files)
Plus locale JSON, drizzle/db snapshots, lockfile, and deleted quick-chat sources. Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
ef4251c to
326f2c3
Compare
326f2c3 to
2bf4d8d
Compare
62dae71 to
0eb98d1
Compare
0eb98d1 to
5c5a68c
Compare
5c5a68c to
84e71c4
Compare
84e71c4 to
4ae54a0
Compare
4ae54a0 to
8f2d387
Compare
8f2d387 to
2573d62
Compare
|
bot: Rejected, no code change (kwf Why: (already implemented, verified live: no change needed: The one flagged added line is the app's cross-platform |
2573d62 to
465cc6c
Compare
465cc6c to
9c1ceed
Compare
Changelog for users
+, reopen one you had, retry a question that never got an answer, and long press a chat to delete it.FEATURE_FLAG_CHAT, off by default.Changelog for maintainers
chatstable and the SDK'ssessions/turns/partson the one encrypted database. The token comes from the app's auth, randomness from expo-crypto, and the data is SQLCipher-encrypted at rest.en.jsondoes not define are removed. The removed keys areprofile.signOut,securityAgent.settingsSave.keepEditing,agentChat.filePart.imageUnavailableWithAlt,agentChat.modelSelector.thinkingEffortXhigh,agentChat.modelSelector.thinkingEffortMedium,agentChat.composer.messagePlaceholder,kiloPass.unavailableDescription,kiloPass.webManagementDescription, andorganization.invoices.loadMoreFailed. A file that also holds an unreviewed value keeps its approved restored values instead of being reverted whole.kiloPass.unavailablecopy becomes "Couldn't load Kilo Pass."; the English subscription description is unchanged.releaseChatreleased the id a chat moved off, which no longer named a running session, so the cleanup cleared nothing. It now resolves the id through the move pointer and ends the chat that carried on, dropping the live state and the pointer. The added test reads both halves after that release: the live chat resets toopening, and the moved-off id stops resolving to it. ReviewreleaseChatfirst: it resolves withsnapshotOf(sessionId).sessionId, so a caller naming a moved-off id ends the live session instead of forgetting a state that no longer exists. The new Android device run is the tip proof for the delete path, replacing the earlier unit-test-only claim for it.E2E proof