Skip to content

Fix Agent Manager tab bar controls#10082

Open
kirillk wants to merge 13 commits intomainfrom
kaput-peach
Open

Fix Agent Manager tab bar controls#10082
kirillk wants to merge 13 commits intomainfrom
kaput-peach

Conversation

@kirillk
Copy link
Copy Markdown
Contributor

@kirillk kirillk commented May 8, 2026

Context

Fix the Agent Manager tab bar so tab creation remains visible and tab tooltips are positioned predictably. The tab strip previously kept the new-tab control before the tabs and title tooltips could appear too high or misaligned relative to the tab.

Implementation

Moved the new-tab split button after the scrollable tab list with full-height separators around the search and add areas. Adjusted tab sizing, hover styling, and tooltip anchors so tab title tooltips center against the full tab and render below the underline with a visible gap, while search, add, and close tooltips keep their expected button behavior.

Screenshots

With h-space

Screen Shot 2026-05-09 at 8 09 27 PM

No h-space

Screen Shot 2026-05-09 at 8 10 00 PM

Demo

GIF Recording 2026-05-08 at 4 40 28 PM

How to Test

  • Open Agent Manager with one or more sessions.
  • Verify the search button is separated from tabs with a full-height separator.
  • Create enough tabs to overflow the row and confirm the + button remains visible after the last visible tab.
  • Hover session, review, and terminal tab titles and confirm tooltips are centered against the tab and appear below the underline with a gap.
  • Hover close, search, and + controls and confirm their tooltips and rounded hover states remain normal.

Get in Touch

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 8, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Previously Reported Issues (now resolved)

Severity File Issue
WARNING packages/kilo-vscode/webview-ui/src/stories/agent-manager.stories.tsx ✅ Fixed — MockTabLeading now correctly contains only the search button; new MockTabAdd component accurately models am-tab-add-wrap with separator and split button.
SUGGESTION packages/kilo-vscode/webview-ui/agent-manager/AgentManagerApp.tsx ✅ Fixed — am-tab-add-wrap (including separator) is now wrapped in <Show when={selection() !== null}> and only renders when a context is selected.
Other Observations (not in diff)

inactive prop removed from tab title tooltips (sortable-tab.tsx, SortableTerminalTab.tsx, SortableReviewTab): Previously, inactive={props.active} suppressed the tab title tooltip when the tab was already active. This prop has been dropped in the refactor, so hovering an active tab will now also show its tooltip. Appears intentional per the PR description.

Files Reviewed (13 files)
  • .changeset/agent-manager-tab-add-button.md
  • .changeset/agent-manager-tab-controls.md
  • packages/kilo-vscode/webview-ui/agent-manager/AgentManagerApp.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/CurrentTabsMenu.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css
  • packages/kilo-vscode/webview-ui/agent-manager/i18n/en.ts
  • packages/kilo-vscode/webview-ui/agent-manager/sortable-tab.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/tab-rendering.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/terminal/SortableTerminalTab.tsx
  • packages/kilo-vscode/webview-ui/src/stories/agent-manager.stories.tsx
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/tab-bar-multiple-tabs-chromium-linux.png (generated baseline, skipped)
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/tab-bar-single-tab-chromium-linux.png (generated baseline, skipped)
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/tab-bar-with-review-tab-chromium-linux.png (generated baseline, skipped)

Reviewed by claude-sonnet-4.6 · 1,968,217 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants