Enable USB Boot protocol support #658
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for Mac OS boot login screen. See https://zmk.dev/docs/config/system#usb > CONFIG_ZMK_USB_BOOT bool Enable USB Boot protocol support n > By default USB Boot protocol support is disabled, however certain situations such as the input of Bitlocker pins or FileVault passwords may require it to be enabled Signed-off-by: Edwin Török <[email protected]>
|
@edwintorok @ReFil FYI, I found the same issue on the "zmkfirmware/zmk" side. The official docs didn't provide details, but
EDIT: |
|
@ReFil Ah, I misunderstood. but thanks for the details and polite reply. And now a good opportunity. Many thanks for maintaining and hardwork the Adv360-Pro-ZMK. I can't thank you enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advantage 360 Pro PR template
What's changed:
Enable USB Boot protocol support for Mac OS login screen (FileVault).
Why has this change been implemented:
When disk encryption is enabled the keyboard doesn't work at all on the initial login screen after power on, it only works after logging in (or on the login screen when resuming from sleep).
On this login screen only the boot protocol works.
According to the ZMK docs enabling
CONFIG_ZMK_USB_BOOTis needed for the keyboard to work with FileVault or Bitlocker:What (if any) actions must a user take after this change:
No action needed other than flashing the new firmware.
See also
@guilhermetk has also implemented a similar change
#511 (comment)
See here for more discussion and testing. I've tested with both Linux (Fedora 41) and Mac OS (with FileVault enabled) and the keyboard with this change works on both. Without the change it doesn't work on the Mac OS initial login screen after poweron (where FileVault needs to be unlocked).
#511 (comment)
#511 (comment)
With older firmwares there were bugs where the keyboard would stop working on Linux when this feature was enabled on both halves, but that bug is gone with latest Kinesis firmware on which this PR is based on top of.