Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HD wallet activation docs #132

Merged
merged 69 commits into from
Mar 4, 2024
Merged

Update HD wallet activation docs #132

merged 69 commits into from
Mar 4, 2024

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Sep 26, 2023

Ref: KomodoPlatform/komodo-defi-framework#1962

  • Update UTXO activation
  • Update QTUM activation
  • Update Accounts section
  • Update Addresses section
  • Update Tx History (v2)
  • Update Withdraw (v2)

Where unclear or unsure, I've added <DevComment> tags. A few things I believe may have been removed (please confirm @shamardy)

  • Is priv_key_policy obsolete in all requests or responses?
  • Does the task::create_new_account::cancel method exist?
  • Has hd_account_id param in MM2.json config been removed?
  • Is there a distinct difference between address_id and address_index, or can we standardise this key in requests/responses?
  • Is there a distinct difference between account_id and account_index, or can we standardise this key in requests/responses?
  • Are the task::withdraw::xxxx methods still used or deprecated?

@smk762 smk762 marked this pull request as draft September 26, 2023 11:07
@smk762
Copy link
Contributor Author

smk762 commented Feb 25, 2024

@gcharang @kivqa This one is ready for review.
@shamardy the HD wallet docs in this PR may need further work, but we will merge as is to avoid conflicts anticipated with the final rebranding PR (Atomicdex -> Komodo Wallet) before making public. Review and rewrite where needed for these docs will be top of the list for docs tasks as soon as the rebranding PR is merged.

Copy link

Preview for merge commit: f4eb1be, available on cloudflare at: https://34841fc0.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: b53eda1, available on cloudflare at: https://1a321e1b.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: 45c6b58, available on cloudflare at: https://8b27acb3.komodo-docs.pages.dev/en/docs/

gcharang and others added 2 commits February 29, 2024 18:39
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update atomicdex methods table
Copy link

Preview for merge commit: e7ea29f, available on cloudflare at: https://9c4e97cd.komodo-docs.pages.dev/en/docs/

…t-updates

[BOT] PR to hd-wallet-updates. Lints file structure, file contents, gets author data, Updates AtomicDEX API Methods Table
Copy link

Preview for merge commit: 2fa6873, available on cloudflare at: https://8798812e.komodo-docs.pages.dev/en/docs/

@gcharang gcharang merged commit 7b6c646 into dev Mar 4, 2024
2 checks passed
Copy link

github-actions bot commented Mar 4, 2024

Preview for merge commit: 5723311, available on cloudflare at: https://d166f1e4.komodo-docs.pages.dev/en/docs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants