Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Update/binary kdf #364

Merged
merged 12 commits into from
Jan 30, 2025
Merged

[wip] Update/binary kdf #364

merged 12 commits into from
Jan 30, 2025

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Oct 30, 2024

closes #312 & #301

  • Update references to binary from mm2 to kdf
  • Update links and filenames

Copy link

Preview for merge commit: d013630, available on cloudflare at: https://6b9e2081.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: d013630, available on cloudflare at: https://7c0b8fb1.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: e25c4e3, available on cloudflare at: https://c71b83c7.komodo-docs.pages.dev/en/docs/

smk762 and others added 2 commits November 14, 2024 05:53
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
Copy link

Preview for merge commit: 3963166, available on cloudflare at: https://33e32212.komodo-docs.pages.dev/en/docs/

@gcharang gcharang self-requested a review January 30, 2025 02:48
| nft\_maker\_swap\_v2\_contract | string | Address for the maker's new V2 NFT swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in mm2 configuration |
| Parameter | Type | Description |
| ------------------------------ | ------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| maker\_swap\_v2\_contract | string | Address for the maker's new V2 swap smart contract. Must be provided if "use\_trading\_proto\_v2"is true in your [MM2.json file](/komodo-defi-framework/setup/configure-mm2-json/) configuration |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't there a transition from mm.json to kdf.json ? if so, we should update this URL and links to it etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet

smk@jarrah:~/mm2_777$ cp MM2.json KDF.json
smk@jarrah:~/mm2_777$ nano KDF.json
smk@jarrah:~/mm2_777$ mv MM2.json MM2_jag.json
smk@jarrah:~/mm2_777$ ./kdf
30 03:15:30, mm2:294] Komodo DeFi Framework 2.3.0-beta DT 
30 03:15:30, mm2:297] File '/home/smk/.kdf/MM2.json' is not present.

Copy link

Preview for merge commit: 9f162ee, available on cloudflare at: https://eb6acb6a.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: 7521f1c, available on cloudflare at: https://777facdd.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: 12e77d4, available on cloudflare at: https://ce1b4e99.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: cbcee0f, available on cloudflare at: https://a08c9c97.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: af81d48, available on cloudflare at: https://22ca1232.komodo-docs.pages.dev/en/docs/

@gcharang gcharang merged commit 9239574 into dev Jan 30, 2025
2 checks passed
@gcharang gcharang deleted the update/binary-kdf branch January 30, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants