Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement translator to translate path segment matching #5734

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

randmonkey
Copy link
Contributor

What this PR does / why we need it:

Implement the translator for path segment matching in Ingresses.

Which issue this PR fixes:

First part of #5485

Special notes for your reviewer:

TODO: implement validating webhooks in path segment matching

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 73.9%. Comparing base (4c459de) to head (e3c4e97).
Report is 3 commits behind head on main.

Files Patch % Lines
internal/admission/validation/ingress/ingress.go 36.3% 6 Missing and 1 partial ⚠️
...ataplane/translator/subtranslator/httproute_atc.go 80.7% 3 Missing and 2 partials ⚠️
.../dataplane/translator/subtranslator/ingress_atc.go 75.0% 3 Missing and 2 partials ⚠️
...rnal/dataplane/translator/subtranslator/ingress.go 25.0% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5734     +/-   ##
=======================================
- Coverage   74.1%   73.9%   -0.2%     
=======================================
  Files        176     176             
  Lines      18187   18244     +57     
=======================================
+ Hits       13477   13497     +20     
- Misses      3719    3745     +26     
- Partials     991    1002     +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 25, 2024
@randmonkey randmonkey force-pushed the feat/translate_path_segment_match branch from 363f96f to d392fd7 Compare March 29, 2024 07:10
@randmonkey randmonkey force-pushed the feat/translate_path_segment_match branch 2 times, most recently from adc86f6 to 7855e63 Compare March 29, 2024 12:51
@randmonkey randmonkey force-pushed the feat/translate_path_segment_match branch from 7855e63 to e3c4e97 Compare April 1, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant