-
Notifications
You must be signed in to change notification settings - Fork 642
Add kotlin.time.Instant serializers #2945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
288f73c
4a0530d
dd9909f
eea8b48
9030611
22a5509
973a6e8
7587980
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -890,6 +890,14 @@ sealed class kotlinx.serialization.modules/SerializersModule { // kotlinx.serial | |
final fun <#A1: kotlin/Any> getContextual(kotlin.reflect/KClass<#A1>): kotlinx.serialization/KSerializer<#A1>? // kotlinx.serialization.modules/SerializersModule.getContextual|getContextual(kotlin.reflect.KClass<0:0>){0§<kotlin.Any>}[0] | ||
} | ||
|
||
final object kotlinx.serialization.builtins/InstantComponentSerializer : kotlinx.serialization/KSerializer<kotlin.time/Instant> { // kotlinx.serialization.builtins/InstantComponentSerializer|null[0] | ||
final val descriptor // kotlinx.serialization.builtins/InstantComponentSerializer.descriptor|{}descriptor[0] | ||
final fun <get-descriptor>(): kotlinx.serialization.descriptors/SerialDescriptor // kotlinx.serialization.builtins/InstantComponentSerializer.descriptor.<get-descriptor>|<get-descriptor>(){}[0] | ||
|
||
final fun deserialize(kotlinx.serialization.encoding/Decoder): kotlin.time/Instant // kotlinx.serialization.builtins/InstantComponentSerializer.deserialize|deserialize(kotlinx.serialization.encoding.Decoder){}[0] | ||
final fun serialize(kotlinx.serialization.encoding/Encoder, kotlin.time/Instant) // kotlinx.serialization.builtins/InstantComponentSerializer.serialize|serialize(kotlinx.serialization.encoding.Encoder;kotlin.time.Instant){}[0] | ||
} | ||
|
||
final object kotlinx.serialization.builtins/LongAsStringSerializer : kotlinx.serialization/KSerializer<kotlin/Long> { // kotlinx.serialization.builtins/LongAsStringSerializer|null[0] | ||
final val descriptor // kotlinx.serialization.builtins/LongAsStringSerializer.descriptor|{}descriptor[0] | ||
final fun <get-descriptor>(): kotlinx.serialization.descriptors/SerialDescriptor // kotlinx.serialization.builtins/LongAsStringSerializer.descriptor.<get-descriptor>|<get-descriptor>(){}[0] | ||
|
@@ -956,6 +964,14 @@ final object kotlinx.serialization.internal/FloatSerializer : kotlinx.serializat | |
final fun serialize(kotlinx.serialization.encoding/Encoder, kotlin/Float) // kotlinx.serialization.internal/FloatSerializer.serialize|serialize(kotlinx.serialization.encoding.Encoder;kotlin.Float){}[0] | ||
} | ||
|
||
final object kotlinx.serialization.internal/InstantSerializer : kotlinx.serialization/KSerializer<kotlin.time/Instant> { // kotlinx.serialization.internal/InstantSerializer|null[0] | ||
final val descriptor // kotlinx.serialization.internal/InstantSerializer.descriptor|{}descriptor[0] | ||
final fun <get-descriptor>(): kotlinx.serialization.descriptors/SerialDescriptor // kotlinx.serialization.internal/InstantSerializer.descriptor.<get-descriptor>|<get-descriptor>(){}[0] | ||
|
||
final fun deserialize(kotlinx.serialization.encoding/Decoder): kotlin.time/Instant // kotlinx.serialization.internal/InstantSerializer.deserialize|deserialize(kotlinx.serialization.encoding.Decoder){}[0] | ||
final fun serialize(kotlinx.serialization.encoding/Encoder, kotlin.time/Instant) // kotlinx.serialization.internal/InstantSerializer.serialize|serialize(kotlinx.serialization.encoding.Encoder;kotlin.time.Instant){}[0] | ||
} | ||
|
||
final object kotlinx.serialization.internal/IntArraySerializer : kotlinx.serialization.internal/PrimitiveArraySerializer<kotlin/Int, kotlin/IntArray, kotlinx.serialization.internal/IntArrayBuilder>, kotlinx.serialization/KSerializer<kotlin/IntArray> // kotlinx.serialization.internal/IntArraySerializer|null[0] | ||
|
||
final object kotlinx.serialization.internal/IntSerializer : kotlinx.serialization/KSerializer<kotlin/Int> { // kotlinx.serialization.internal/IntSerializer|null[0] | ||
|
@@ -1074,6 +1090,7 @@ final val kotlinx.serialization.modules/EmptySerializersModule // kotlinx.serial | |
final fun <get-EmptySerializersModule>(): kotlinx.serialization.modules/SerializersModule // kotlinx.serialization.modules/EmptySerializersModule.<get-EmptySerializersModule>|<get-EmptySerializersModule>(){}[0] | ||
|
||
final fun (kotlin.time/Duration.Companion).kotlinx.serialization.builtins/serializer(): kotlinx.serialization/KSerializer<kotlin.time/Duration> // kotlinx.serialization.builtins/serializer|[email protected](){}[0] | ||
final fun (kotlin.time/Instant.Companion).kotlinx.serialization.builtins/serializer(): kotlinx.serialization/KSerializer<kotlin.time/Instant> // kotlinx.serialization.builtins/serializer|[email protected](){}[0] | ||
final fun (kotlin.uuid/Uuid.Companion).kotlinx.serialization.builtins/serializer(): kotlinx.serialization/KSerializer<kotlin.uuid/Uuid> // kotlinx.serialization.builtins/serializer|[email protected](){}[0] | ||
final fun (kotlin/Boolean.Companion).kotlinx.serialization.builtins/serializer(): kotlinx.serialization/KSerializer<kotlin/Boolean> // kotlinx.serialization.builtins/serializer|[email protected](){}[0] | ||
final fun (kotlin/Byte.Companion).kotlinx.serialization.builtins/serializer(): kotlinx.serialization/KSerializer<kotlin/Byte> // kotlinx.serialization.builtins/serializer|[email protected](){}[0] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
/* | ||
* Copyright 2025-2025 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license. | ||
*/ | ||
|
||
package kotlinx.serialization.builtins | ||
|
||
import kotlinx.serialization.* | ||
import kotlinx.serialization.descriptors.* | ||
import kotlinx.serialization.encoding.* | ||
import kotlin.time.ExperimentalTime | ||
import kotlin.time.Instant | ||
|
||
/** | ||
* Serializer that encodes and decodes [Instant] as its second and nanosecond components of the Unix time. | ||
* | ||
* JSON example: `{"epochSeconds":1607505416,"nanosecondsOfSecond":124000}`. | ||
*/ | ||
@ExperimentalTime | ||
public object InstantComponentSerializer : KSerializer<Instant> { | ||
sandwwraith marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
override val descriptor: SerialDescriptor = | ||
buildClassSerialDescriptor("kotlinx.serialization.InstantComponentSerializer") { | ||
element<Long>("epochSeconds") | ||
element<Long>("nanosecondsOfSecond", isOptional = true) | ||
} | ||
|
||
@OptIn(ExperimentalSerializationApi::class) | ||
override fun deserialize(decoder: Decoder): Instant = | ||
decoder.decodeStructure(descriptor) { | ||
var epochSecondsNotSeen = true | ||
var epochSeconds: Long = 0 | ||
var nanosecondsOfSecond = 0 | ||
while (true) { | ||
when (val index = decodeElementIndex(descriptor)) { | ||
0 -> { | ||
epochSecondsNotSeen = false | ||
epochSeconds = decodeLongElement(descriptor, 0) | ||
} | ||
1 -> nanosecondsOfSecond = decodeIntElement(descriptor, 1) | ||
CompositeDecoder.DECODE_DONE -> break | ||
else -> throw SerializationException("Unexpected index: $index") | ||
} | ||
} | ||
if (epochSecondsNotSeen) throw MissingFieldException( | ||
missingField = "epochSeconds", | ||
serialName = descriptor.serialName | ||
) | ||
Instant.fromEpochSeconds(epochSeconds, nanosecondsOfSecond) | ||
} | ||
|
||
@OptIn(ExperimentalSerializationApi::class) | ||
override fun serialize(encoder: Encoder, value: Instant) { | ||
encoder.encodeStructure(descriptor) { | ||
encodeLongElement(descriptor, 0, value.epochSeconds) | ||
if (value.nanosecondsOfSecond != 0) { | ||
encodeIntElement(descriptor, 1, value.nanosecondsOfSecond) | ||
} | ||
Comment on lines
+55
to
+57
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should have a call to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It depends on whether we really want to include Current behavior would be equal to having There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @sandwwraith The issue is for a fixed length format that requires all attributes to be serialized (for example Android's Parcelable). In such case there must be bits written to represent the default value. It is not possible to write a placeholder as any placeholder value could be a valid value, so either the actual default is written or a marker is written (changing the wire format to add a marker byte). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @sandwwraith I've played around a bit and added binary tests to the jsonTests in #2979 . This is based upon the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure what the problem is. Descriptor says that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Why? I think you're confusing optionality support with coercion support, which is done via There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @sandwwraith It will not decode 0, it will decode whatever bytes are following the What I am describing is a format that must be read sequentially and does not have the ability to inspect the bytestream to determine the next element ( You are assuming that the decoder never returns 1 from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To show it breaks I have created another branch applying the binary test to the InstantSerializer: This test fails to decode because it tries to decode the Btw. I've also updated the branch underlying #2979. It now triggers more often (and the binary format has been rewritten to support out-of-order serialization). There were two sets of changes needed. The error message test needed to be adjusted to check the correct message. More interesting is that for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see what you mean. Do you have any real-world examples of such formats? IIRC, even binary formats with schema (such as Protobuf or Avro) have some way of denoting the id of the next element in the stream (e.g., protoId). Still, it would mean that such a format is unable to support Besides, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are quite some cases (not supported by kotlinx.serialization). I have looked at some examples:
It is also common in many binary file formats (e.g. PNG, ZIP) or binary network protocols (IP/TCP/TLS/HTTP2.0/dbus) - but even textual line separated formats (e.g. Advent of code data) would may not be self-describing. The The fix for this case would be where the format can influence behaviour (by default it returns false and constant folding should be able to easily optimize the call away): if (value.nanosecondsOfSecond != 0 || shouldEncodeElementDefault(descriptor, 1)) { As to |
||
} | ||
} | ||
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
/* | ||
* Copyright 2025-2025 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license. | ||
*/ | ||
|
||
package kotlinx.serialization | ||
|
||
import kotlinx.serialization.* | ||
import kotlinx.serialization.json.* | ||
import kotlinx.serialization.builtins.* | ||
import kotlin.time.* | ||
import kotlin.test.* | ||
import kotlin.reflect.typeOf | ||
|
||
@OptIn(ExperimentalTime::class) | ||
class InstantSerializationTest: JsonTestBase() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It may be worthwhile to also test on another format that is not |
||
private fun iso8601Serialization(serializer: KSerializer<Instant>) { | ||
for ((instant, json) in listOf( | ||
Pair(Instant.fromEpochSeconds(1607505416, 124000), | ||
"\"2020-12-09T09:16:56.000124Z\""), | ||
Pair(Instant.fromEpochSeconds(-1607505416, -124000), | ||
"\"1919-01-23T14:43:03.999876Z\""), | ||
Pair(Instant.fromEpochSeconds(987654321, 123456789), | ||
"\"2001-04-19T04:25:21.123456789Z\""), | ||
Pair(Instant.fromEpochSeconds(987654321, 0), | ||
"\"2001-04-19T04:25:21Z\""), | ||
Comment on lines
+17
to
+25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should include some values with non-utc timezones (especially ones with strange offsets like India). And include the fraction handling with millis, or less than 3 digits in the fraction of seconds. |
||
)) { | ||
assertJsonFormAndRestored(serializer, instant, json) | ||
} | ||
for ((instant, json) in listOf( | ||
Pair(Instant.fromEpochSeconds(987654321, 123456789), | ||
"\"2001-04-19T07:55:21.123456789+03:30\""), | ||
Pair(Instant.fromEpochSeconds(987654321, 123456789), | ||
"\"2001-04-19T00:55:21.123456789-03:30\""), | ||
)) { | ||
assertRestoredFromJsonForm(serializer, json, instant) | ||
} | ||
} | ||
|
||
private fun componentSerialization(serializer: KSerializer<Instant>) { | ||
for ((instant, json) in listOf( | ||
Pair(Instant.fromEpochSeconds(1607505416, 124000), | ||
"{\"epochSeconds\":1607505416,\"nanosecondsOfSecond\":124000}"), | ||
Pair(Instant.fromEpochSeconds(-1607505416, -124000), | ||
"{\"epochSeconds\":-1607505417,\"nanosecondsOfSecond\":999876000}"), | ||
Pair(Instant.fromEpochSeconds(987654321, 123456789), | ||
"{\"epochSeconds\":987654321,\"nanosecondsOfSecond\":123456789}"), | ||
Pair(Instant.fromEpochSeconds(987654321, 0), | ||
"{\"epochSeconds\":987654321}"), | ||
)) { | ||
assertJsonFormAndRestored(serializer, instant, json) | ||
} | ||
// check that having a `"nanosecondsOfSecond": 0` field doesn't break deserialization | ||
assertEquals(Instant.fromEpochSeconds(987654321, 0), | ||
Json.decodeFromString(serializer, | ||
"{\"epochSeconds\":987654321,\"nanosecondsOfSecond\":0}")) | ||
// "epochSeconds" should always be present | ||
assertFailsWith<SerializationException> { Json.decodeFromString(serializer, "{}") } | ||
assertFailsWith<SerializationException> { Json.decodeFromString(serializer, "{\"nanosecondsOfSecond\":3}") } | ||
} | ||
|
||
@Test | ||
fun testIso8601Serialization() { | ||
iso8601Serialization(Instant.serializer()) | ||
} | ||
|
||
@Test | ||
fun testComponentSerialization() { | ||
componentSerialization(InstantComponentSerializer) | ||
} | ||
|
||
@Test | ||
fun testDefaultSerializers() { | ||
// should be the same as the ISO 8601 | ||
@Suppress("UNCHECKED_CAST") | ||
iso8601Serialization(serializer(typeOf<Instant>()) as KSerializer<Instant>) | ||
// iso8601Serialization(serializer()) TODO: uncomment when the compiler adds KT-75759 | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parenthesis is not a typo, it's there because the format is called
b)
in that part of the ISO document.