Fix ProtoBuf schema generation for value classes in collections - #3206
Open
saar wants to merge 1 commit into
Open
Fix ProtoBuf schema generation for value classes in collections#3206saar wants to merge 1 commit into
saar wants to merge 1 commit into
Conversation
The schema generator only unwrapped `@JvmInline` value classes for plain message fields. Inside a `List`, `Array`, or as a `Map` value the value class was left wrapped, so the schema used the wrapper type and added an extra message for it. Unwrapping is now shared in a small `unwrapInlineType` helper and applied in `generateListType` and `generateMapType`. Packed repeated fields and map keys are unchanged. Fixes Kotlin#3205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema generator only unwrapped
@JvmInlinevalue classes for plain message fields. Inside aList,Array, or as aMapvalue the value class was left wrapped, so the schema used the wrapper type and added an extra message for it.Unwrapping is now shared in a small
unwrapInlineTypehelper and applied ingenerateListTypeandgenerateMapType. Packed repeated fields and map keys are unchanged.Added
InlineClassesInCollectionsto the schema generation test, covering a value class in aList, anArray, and aMapvalue.Fixes #3205