Skip to content

Conversation

@ColdsteelRail
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ColdsteelRail ColdsteelRail changed the title Xset dev refactor: abstract collaset code with kube-xset Nov 20, 2025
@ColdsteelRail ColdsteelRail changed the title refactor: abstract collaset code with kube-xset refactor: abstract collaset code with kusionstack/kube-xset Nov 20, 2025
@ColdsteelRail ColdsteelRail force-pushed the xset-dev branch 3 times, most recently from 38302d4 to 62cd424 Compare November 20, 2025 07:47
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 77.59259% with 121 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.01%. Comparing base (7e58740) to head (99f7547).

Files with missing lines Patch % Lines
pkg/controllers/collaset/pod_updater.go 69.88% 34 Missing and 19 partials ⚠️
pkg/controllers/collaset/decoration_adapter.go 63.41% 20 Missing and 10 partials ⚠️
pkg/controllers/collaset/collaset_controller.go 92.69% 10 Missing and 3 partials ⚠️
pkg/controllers/collaset/utils/pod.go 0.00% 10 Missing ⚠️
pkg/controllers/collaset/legacy/pvc_control.go 0.00% 9 Missing ⚠️
pkg/controllers/collaset/lifecycle_adapter.go 80.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   38.67%   46.01%   +7.34%     
==========================================
  Files         128      123       -5     
  Lines        9479     7656    -1823     
==========================================
- Hits         3666     3523     -143     
+ Misses       5479     3812    -1667     
+ Partials      334      321      -13     
Flag Coverage Δ
unittests 46.01% <77.59%> (+7.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@zoumo zoumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zoumo zoumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ColdsteelRail ColdsteelRail merged commit 9684048 into main Nov 20, 2025
13 checks passed
@ColdsteelRail ColdsteelRail deleted the xset-dev branch November 20, 2025 12:45
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力

3 participants