Skip to content

Add 'cumulative percent' contribution analysis mode #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

marc-vdm
Copy link
Member

@marc-vdm marc-vdm commented Jan 16, 2025

Adds 'cumulative percent' as a contribution analysis type in AB.

current types:

  • Relative (refactored to Percent): shows contributors of at least n%
  • Top # (refactored to Number): shows highest n contributors

New type would show a cumulative percentage, all (sorted) contributions that together reach at least n%.
e.g. in the process contributions example a cumulative percent set to 60% would only show steel production, with 80% it would show both steel production and electricity production.

This is relevant to add as e.g. the PEF regulations require the cumulative 80% contributors to be reported (chapter 6.3):

The most relevant processes are those that collectively contribute to at least 80% to any of the most relevant impact categories identified

Issues:

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@coveralls
Copy link

coveralls commented Jan 16, 2025

Coverage Status

coverage: 53.056% (-0.05%) from 53.102%
when pulling f1a4f1b on marc-vdm:cum_percent_ca
into 3ca631b on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm added the change PRs related to minor changes to AB label Apr 8, 2025
@marc-vdm marc-vdm added this to the 2.11.2 milestone Apr 8, 2025
@marc-vdm marc-vdm requested review from mrvisscher and Copilot April 8, 2025 09:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

@marc-vdm marc-vdm marked this pull request as ready for review April 8, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change PRs related to minor changes to AB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cumulative percent mode to contribution analysis contribution analysis, add another cutoff method
2 participants