Adding auto generated toString method for structs #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angelina <[email protected]>
|
What does this PR do?
|
gtebrean
commented
Mar 20, 2025
| //String actualMethodBody = toStringMethod.toString(); | ||
| //assertTrue(actualMethodBody.contains("return \"{ name='\" + name + \"', age='\" + age + \"' }\";")); | ||
| //assertTrue(actualMethodBody.contains(expectedFormat), "The toString method was not generated correctly."); | ||
| assertTrue(actualMethodBody.contains("return \"{ name='\" + name + \"', age='\" + age + \"' }\";"), |
There was a problem hiding this comment.
Suggested change
| assertTrue(actualMethodBody.contains("return \"{ name='\" + name + \"', age='\" + age + \"' }\";"), | |
| assertTrue(actualMethodBody.contains("return \"{ name='\" + name + \"', age='\" + age + \"', }\";"), |
This will fix the current test.
However I have some points about the current approach.
- If this is just a dreft is fine, else copy /pasting the code in this class in a private method to test it is not the right thing.
- For the moment I will stop do any changes on Solidity wrapper generator and have a look at what we have right now in this file you can find how to generate smart contracts with stucts https://blog.web3labs.com/hyperledger-web3j-truly-decode-support-for-dynamic-solidity-structs/.
- There are 2 ways to do it, first I would recommend to check what to string returns on a TypeReference struct and if we can update only that class.
- 2nd check the final wrapper where exactly should be the to string written when there is a struct (in both cases TypeReference and Struct class type),
By covering this we can make a plan and start implementing.
There was a problem hiding this comment.
Hi, @gtebrean Thank you!
- I corrected the issues with the code and test code.
- Sounds good, if I can help please let me know.
- I will take a look at TypeRefrence to see what is returned.
- Ill double check and see where this should be placed.
Julius278
reviewed
Mar 25, 2025
| @@ -519,6 +519,7 @@ private List<TypeSpec> buildStructTypes(final List<AbiDefinition> functionDefini | |||
| final TypeSpec.Builder builder = | |||
| TypeSpec.classBuilder(structName) | |||
| .addModifiers(Modifier.PUBLIC, Modifier.STATIC); | |||
| builder.addMethod(generateToStringMethod(namedType.getComponents())); // ADDED THIS LINE | |||
There was a problem hiding this comment.
Hey @aceppaluni,
I guess you wont need a comment here
There was a problem hiding this comment.
Hi @Julius278 That was my mistake. They were left behind from when I was testing. Ill be sure to remove then, thank you!
Julius278
reviewed
Mar 25, 2025
| @@ -602,6 +603,7 @@ private List<TypeSpec> buildStructTypes(final List<AbiDefinition> functionDefini | |||
|
|
|||
| builder.superclass(namedType.isDynamic() ? DynamicStruct.class : StaticStruct.class); | |||
| builder.addMethod(constructorBuilder.build()); | |||
| builder.addMethod(generateToStringMethod(namedType.getComponents())); // Added this line | |||
There was a problem hiding this comment.
same here, no comment needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
required
Where should the reviewer start?
required
Why is it needed?
required
Checklist