Skip to content

Conversation

@GTC6244
Copy link
Contributor

@GTC6244 GTC6244 commented Nov 24, 2025

WHAT

Create additional keysets at any epoch.

Copilot AI review requested due to automatic review settings November 24, 2025 22:45
Copilot finished reviewing on behalf of GTC6244 November 24, 2025 22:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates test code to use a more specific signing function and enhances observability in the DKG (Distributed Key Generation) system by improving logging and adding key set identifiers to DKG IDs.

  • Refactored test_add_second_keyset to use simple_single_sign_with_hd_key instead of sign_with_each_curve_type
  • Enhanced DKG ID formatting to include key set identifiers for better tracking
  • Improved trace logging in epoch change logic to show key set identifiers

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
rust/lit-node/lit-node/tests/integration/keysets.rs Replaced multi-curve testing function with single-curve test calls, removed unused variable
rust/lit-node/lit-node/src/tss/dkg/manager.rs Added key set identifier to epoch_dkg_id format for better DKG operation tracking
rust/lit-node/lit-node/src/tasks/fsm/epoch_change.rs Enhanced trace logging to display key set identifiers and improved warning messages with context

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GTC6244 GTC6244 changed the title Update test Keysets - handle multiples in DKG. Nov 25, 2025
@GTC6244 GTC6244 self-assigned this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants