Restore version upgrade tests #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PASS [ 43.556s] (3/3) lit_node::test toxiproxy::perf_tests::load_with_no_latency |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores previously commented-out version upgrade tests by refactoring them to use the standardized TestSetupBuilder pattern instead of manual test setup code.
- Refactored three version upgrade tests to use
TestSetupBuilderfor cleaner, more consistent test initialization - Removed manual contract and validator setup boilerplate code
- Updated
NetworkIntegrityCheckerinstantiation to use the new API signature requiring bothend_userandactionsparameters
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
rust/lit-node/lit-node/tests/upgrades/version_upgrades.rs |
Refactored three version upgrade tests to use TestSetupBuilder, removed manual setup code, updated API calls, but missing custom_binary_path usage for the third test |
rust/lit-node/lit-node/tests/test.rs |
Re-enabled the upgrades test module by uncommenting it |
rust/lit-node/lit-node/src/git_info.rs |
Updated git commit hash to reflect current commit |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR restores previously commented-out version upgrade tests by refactoring them to use the standardized
TestSetupBuilderpattern instead of manual test setup code.TestSetupBuilderfor cleaner, more consistent test initializationNetworkIntegrityCheckerinstantiation to use the new API signature requiring bothend_userandactionsparametersWARNING !
The main test now proves that code is backwards compatible to a given branch/release.. It does NOT prove that a particular methodology for upgrading nodes work - outside of deploying new nodes with new stakers and dealing them in, while dealing out old nodes.