Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop AMS Stager mechanism properly #95

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Stop AMS Stager mechanism properly #95

merged 2 commits into from
Feb 26, 2025

Conversation

lpottier
Copy link
Collaborator

This PR allows RMQPipeline to stop properly when receiving a signal (SIGINT or SIGUSR1).

@lpottier
Stop stager in a clean manner
104bd93 
Signed-off-by: Loic Pottier <[email protected]>
@lpottier lpottier changed the title Stop stager in a clean manner Stop stager properly Feb 26, 2025
@lpottier lpottier changed the title Stop stager properly Stop AMS Stager mechanism properly Feb 26, 2025
@lpottier lpottier requested a review from koparasy February 26, 2025 00:18
koparasy
koparasy approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@koparasy koparasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpottier This LGTM, I did a push to try to fix a issue on our CI. If tests pass I will merge in.

@koparasy koparasy merged commit d71ba86 into develop Feb 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koparasy koparasy koparasy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpottier @koparasy