Issue/658/api break for numcosmo [version:1.16.9]

[caioolivv]

No description provided.

[coveralls]

coverage: 100.0%. remained the same
when pulling 03ae4d0 on issue/658/api_break_for_numcosmo
into 86faa10 on main.

[m-aguena]

Hi @caioolivv can you check these changes are still valid? I installed the new version of numcosmo (numcosmo-0.24.0) and got the error

AttributeError: 'gi.repository.NumCosmo' object has no attribute 'HaloDensityProfileMassDef'

[caioolivv]

Hi @m-aguena, I couldn't reproduce it. What exactly did you run that ended up on this error? I ran all notebooks that use NumCosmo and they are mostly fine (with exception of a function HICosmo.new_from_name() that was deprecated a couple of years ago and wasn't updated).

[m-aguena]

Hi @m-aguena, I couldn't reproduce it. What exactly did you run that ended up on this error? I ran all notebooks that use NumCosmo and they are mostly fine (with exception of a function HICosmo.new_from_name() that was deprecated a couple of years ago and wasn't updated).

@caioolivv my impression is that somehow an older version of numcosmo is being used, even though I installed it from scrach on a new computer. Which version fo numcosmo are you using here?

[caioolivv]

I was using numcosmo 0.24.0, but 0.25.0 has just been pushed. I'll have to test with the new version.

[m-aguena]

@caioolivv thanks for the work! It seems the changes are working now, but the Example2_Fit_Halo_Mass_to_Shear_Catalog_NC.ipynb notebook is still failing:

AttributeError: 'NoneType' object has no attribute 'mid'

[caioolivv]

@caioolivv thanks for the work! It seems the changes are working now, but the Example2_Fit_Halo_Mass_to_Shear_Catalog_NC.ipynb notebook is still failing:

AttributeError: 'NoneType' object has no attribute 'mid'

Just fixed it, but that reminds me of two things:

1. I've just updated for numcosmo<=0.24. Versions 0.25 and up have a different problem that I'll have to think about... in another PR.
2. This Example2_Fit_Halo_Mass_to_Shear_Catalog_NC.ipynb notebook contains an old unbinned likelihood model that has been completely reworked to a new version we've discussed adding to a fitting module in CLMM. I think we leave this as is at the moment and edit it only when we decide how to add the new unbinned likelihood method.

[m-aguena]

@caioolivv thanks for the work! It seems the changes are working now, but the Example2_Fit_Halo_Mass_to_Shear_Catalog_NC.ipynb notebook is still failing:

AttributeError: 'NoneType' object has no attribute 'mid'

Just fixed it, but that reminds me of two things:

1. I've just updated for numcosmo<=0.24. Versions 0.25 and up have a different problem that I'll have to think about... in another PR.
2. This Example2_Fit_Halo_Mass_to_Shear_Catalog_NC.ipynb notebook contains an old unbinned likelihood model that has been completely reworked to a new version we've discussed adding to a fitting module in CLMM. I think we leave this as is at the moment and edit it only when we decide how to add the new unbinned likelihood method.

Agreed, can you create an issue to remember of revisiting Example2_Fit_Halo_Mass_to_Shear_Catalog_NC.ipynb in the future? Thanks

[m-aguena]

Thanks for handling this!