Skip to content

Test ccdgains #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeremyneveu merged 25 commits into from
Jan 11, 2026
Merged

Test ccdgains #177

jeremyneveu merged 25 commits into from
Jan 11, 2026

Conversation

@jeremyneveu
Copy link
Collaborator

@jeremyneveu jeremyneveu commented Nov 21, 2025 •
edited
Loading

this PR contains:

  • robust pyproject.toml file
  • debug of simbad votable field depending on astroquery version
  • debug of fixing condition in Newton gradient descent when jacobian is nearly zero
  • better CCD gain propagation in the code

jeremyneveu and others added 22 commits November 21, 2025 15:16
@jeremyneveu
fix A1
93cf8c6
@jeremyneveu
change function name into load_transmission_file
3642949
@jeremyneveu
auxtel throughput rescaled by 1.30/1.1
7e38a21
@jeremyneveu
remove wavelengths above 1100nm
73858f4
@jeremyneveu
rescale by 1.30552 / 1.1 to account for bad gain value (1.1 instead o…
05699bd 
…f 1.3) when determining this transmission
@jeremyneveu
free A2 and free A1
7b3c185
@corentinravoux
small fix for compatibility with gaiaspec
86e1a15
@corentinravoux
Improve hardcoded votable field
8a2a42d
@corentinravoux
fix
80b81f8
@corentinravoux
last fix
c48cfd4
@jeremyneveu
merge with v3.2.1
7272569
@jeremyneveu
add chi2 and outlier numbers in extra parameter results
958fe4f
@jeremyneveu
robuts test of null jacobian adapted to different machine precision
1b3a148
@jeremyneveu
extend angstrom_exp bounds to (0,4)
1b6b6af
@jeremyneveu
Merge branch 'master' into test_ccdgains
be3ff1c
@jeremyneveu
add len(touliers) in extra
a1b6a0f
@jeremyneveu
Merge branch 'test_ccdgains' of github.com:LSSTDESC/Spectractor into …
0df9e88 
…test_ccdgains
@corentinravoux
Solution to avoid linalg errors in the linear system evaluation
3f9a9d8
@jeremyneveu
Merge branch 'test_ccdgains' of https://github.com/LSSTDESC/Spectractor…
bb3572d 
… into test_ccdgains
@jeremyneveu
explicit A1 fixed value
9b37109
@jeremyneveu
J maybe a list of list so remove J.shape[1]
ad75659
@jeremyneveu
obsolete np.trapz
4120b70
@coveralls
Copy link

coveralls commented Dec 16, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 20445768673

Details

  • 30 of 33 (90.91%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 89.05%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spectractor/extractor/targets.py 2 3 66.67%
spectractor/tools.py 3 5 60.0%
Totals Coverage Status
Change from base Build 19987407473: 1.1%
Covered Lines: 7441
Relevant Lines: 8356
💛 - Coveralls

@jeremyneveu jeremyneveu merged commit cc1c95c into master Jan 11, 2026
2 checks passed
@jeremyneveu jeremyneveu deleted the test_ccdgains branch January 15, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeremyneveu @coveralls @corentinravoux