Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 98.35% 98.36% +0.01%
==========================================
Files 28 28
Lines 1758 1772 +14
Branches 57 58 +1
==========================================
+ Hits 1729 1743 +14
Misses 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
m-aguena
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, doing the interpolation for the exact recipe, in
is not giving good results. Also since we expect the
cluster_theoryhas to be prepared with the beta parameters, I think it also should be prepared with the right beta interpolation, the same way we do for the grid recipe.To see the error, just run the
cluster_recipe.ipynbnotebook in #63.Without this fix, the figure in Cell 7,
Reduced Shear — Exact vs Grid (No Interp) for 3 Radiishows that the prediction do not agree, even though both are prepared with the samecluster_theory object.